Fix class finalization issues in kernel

Fix class finalization issues in kernel

Without this we'll get something like
```
../../runtime/vm/class_finalizer.cc: 2525: error: expected: cls.is_type_finalized()
Dumping native stack trace for thread 1b6fc
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x0000000000692a21] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x0000000000698420] dart::ClassFinalizer::FinalizeClass(dart::Class const&)
[...]
```

when running via kernel with command line option --error_on_bad_override

This is caused by finalizing a class having a interface not yet type finalized.

This change makes sure types are finalized before the class using them is.

Fixes https://github.com/dart-lang/sdk/issues/29123

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/242be22300c3cfb99b298651a92237aced3a86fd

[jensj, 2017-03-22 10:59:24]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[jensj, 2017-03-22 10:59:25]

Probably another solution could be to order the class_array somehow...

[Kevin Millikin (Google), 2017-03-22 11:29:50]

LGTM.

[jensj, 2017-03-22 11:32:36]

Description was changed from

==========
Fix class finalization issues in kernel

Without this we'll get something like
```
../../runtime/vm/class_finalizer.cc: 2525: error: expected:
cls.is_type_finalized()
Dumping native stack trace for thread 1b6fc
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x0000000000692a21] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x0000000000698420] dart::ClassFinalizer::FinalizeClass(dart::Class const&)
[...]
```

when running via kernel with command line option --error_on_bad_override

This is caused by finalizing a class having a interface not yet type finalized.

This change makes sure types are finalized before the class using them is.

Fixes https://github.com/dart-lang/sdk/issues/29123
==========

to

==========
Fix class finalization issues in kernel

Without this we'll get something like
```
../../runtime/vm/class_finalizer.cc: 2525: error: expected:
cls.is_type_finalized()
Dumping native stack trace for thread 1b6fc
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x00000000009b6353] dart::Profiler::DumpStackTrace()
  [0x0000000000692a21] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x0000000000698420] dart::ClassFinalizer::FinalizeClass(dart::Class const&)
[...]
```

when running via kernel with command line option --error_on_bad_override

This is caused by finalizing a class having a interface not yet type finalized.

This change makes sure types are finalized before the class using them is.

Fixes https://github.com/dart-lang/sdk/issues/29123

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/242be22300c3cfb99b298651a92237aced3a86fd
==========

[jensj, 2017-03-22 11:32:38]

Committed patchset #1 (id:1) manually as
242be22300c3cfb99b298651a92237aced3a86fd (presubmit successful).