Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 2766173002: Fix class finalization issues in kernel (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index 6d834559091b5d0cbf204b41578de87c54b3ae20..c78900ae671c4e9ba89ff0c9910430bd07dca1d3 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -153,13 +153,18 @@ bool ClassFinalizer::ProcessPendingClasses(bool from_kernel) {
for (intptr_t i = 0; i < class_array.Length(); i++) {
cls ^= class_array.At(i);
FinalizeTypesInClass(cls);
- // Classes compiled from Dart sources are finalized more lazily, classes
- // compiled from Kernel binaries can be finalized now (and should be,
- // since we will not revisit them).
- if (from_kernel) {
+ }
+
+ // Classes compiled from Dart sources are finalized more lazily, classes
+ // compiled from Kernel binaries can be finalized now (and should be,
+ // since we will not revisit them).
+ if (from_kernel) {
+ for (intptr_t i = 0; i < class_array.Length(); i++) {
+ cls ^= class_array.At(i);
FinalizeClass(cls);
}
}
+
if (FLAG_print_classes) {
for (intptr_t i = 0; i < class_array.Length(); i++) {
cls ^= class_array.At(i);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698