Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2766153002: Don't compile PasswordManagerBrowserTestBase on Android (Closed)

Created:
3 years, 9 months ago by vasilii
Modified:
3 years, 9 months ago
Reviewers:
jdoerrie
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't compile PasswordManagerBrowserTestBase on Android BUG=703305 Review-Url: https://codereview.chromium.org/2766153002 Cr-Commit-Position: refs/heads/master@{#458715} Committed: https://chromium.googlesource.com/chromium/src/+/47d59c35b288edbf4ded983949c0f5b0c4f3c5e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
vasilii
Hi Jan, please review the CL.
3 years, 9 months ago (2017-03-22 10:15:43 UTC) #4
jdoerrie
lgtm
3 years, 9 months ago (2017-03-22 10:28:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766153002/1
3 years, 9 months ago (2017-03-22 10:58:19 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:21:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47d59c35b288edbf4ded983949c0...

Powered by Google App Engine
This is Rietveld 408576698