Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2858)

Unified Diff: chrome/app/settings_strings.grdp

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: add tests for home button urls Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index 61993ae8a1f6f0475b0dd8445561d1dbf2833c7c..5acbc6c9aea86679c34e1fbdc139296fdecf7e7b 100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -240,6 +240,9 @@
<message name="IDS_SETTINGS_HOME_BUTTON_DISABLED" desc="Sub label for the Show home button setting when disabled.">
Disabled
</message>
+ <message name="IDS_SETTINGS_HOME_URL_NOT_VALID" desc="Text indicating that the input to the custom home url is not invalid.">
+ Not valid
dpapad 2017/03/24 01:39:31 Can we reuse/repurpose the existing identical mess
scottchen 2017/03/24 20:48:54 I feel like there's always a good chance strings u
dpapad 2017/03/24 21:47:43 I think is better to be frugal with our strings an
scottchen 2017/03/24 22:56:30 Acknowledged.
+ </message>
<message name="IDS_SETTINGS_SET_WALLPAPER" desc="Name of the control which allows the user to set the wallpaper.">
Wallpaper
</message>

Powered by Google App Engine
This is Rietveld 408576698