Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/app/settings_strings.grdp

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: add tests for home button urls Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Settings-specific strings (included from generated_resources.grd). --> 2 <!-- Settings-specific strings (included from generated_resources.grd). -->
3 <grit-part> 3 <grit-part>
4 <!-- Main Page --> 4 <!-- Main Page -->
5 <if expr="chromeos"> 5 <if expr="chromeos">
6 <message name="IDS_SETTINGS_SECONDARY_USER_BANNER" desc="Banner displayed in settings page when the user is secondary in a multi-profile session."> 6 <message name="IDS_SETTINGS_SECONDARY_USER_BANNER" desc="Banner displayed in settings page when the user is secondary in a multi-profile session.">
7 Some settings belonging to <ph name="PRIMARY_EMAIL">$1<ex>john@google.com< /ex></ph> are being shared with you. These settings only affect your account whe n using multiple sign-in. 7 Some settings belonging to <ph name="PRIMARY_EMAIL">$1<ex>john@google.com< /ex></ph> are being shared with you. These settings only affect your account whe n using multiple sign-in.
8 </message> 8 </message>
9 </if> 9 </if>
10 10
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 </message> 233 </message>
234 <message name="IDS_SETTINGS_CUSTOM_WEB_ADDRESS" desc="Sub label describing an empty custom web address for the Show home button setting."> 234 <message name="IDS_SETTINGS_CUSTOM_WEB_ADDRESS" desc="Sub label describing an empty custom web address for the Show home button setting.">
235 Custom 235 Custom
236 </message> 236 </message>
237 <message name="IDS_SETTINGS_ENTER_CUSTOM_WEB_ADDRESS" desc="Input label for a custom web address for the Show home button setting."> 237 <message name="IDS_SETTINGS_ENTER_CUSTOM_WEB_ADDRESS" desc="Input label for a custom web address for the Show home button setting.">
238 Enter custom web address 238 Enter custom web address
239 </message> 239 </message>
240 <message name="IDS_SETTINGS_HOME_BUTTON_DISABLED" desc="Sub label for the Show home button setting when disabled."> 240 <message name="IDS_SETTINGS_HOME_BUTTON_DISABLED" desc="Sub label for the Show home button setting when disabled.">
241 Disabled 241 Disabled
242 </message> 242 </message>
243 <message name="IDS_SETTINGS_HOME_URL_NOT_VALID" desc="Text indicating that the input to the custom home url is not invalid.">
244 Not valid
dpapad 2017/03/24 01:39:31 Can we reuse/repurpose the existing identical mess
scottchen 2017/03/24 20:48:54 I feel like there's always a good chance strings u
dpapad 2017/03/24 21:47:43 I think is better to be frugal with our strings an
scottchen 2017/03/24 22:56:30 Acknowledged.
245 </message>
243 <message name="IDS_SETTINGS_SET_WALLPAPER" desc="Name of the control which all ows the user to set the wallpaper."> 246 <message name="IDS_SETTINGS_SET_WALLPAPER" desc="Name of the control which all ows the user to set the wallpaper.">
244 Wallpaper 247 Wallpaper
245 </message> 248 </message>
246 <message name="IDS_SETTINGS_THEMES" desc="Name of the control which allows the user to get a theme for the browser."> 249 <message name="IDS_SETTINGS_THEMES" desc="Name of the control which allows the user to get a theme for the browser.">
247 Themes 250 Themes
248 </message> 251 </message>
249 <if expr="is_linux and not chromeos"> 252 <if expr="is_linux and not chromeos">
250 <message name="IDS_SETTINGS_SYSTEM_THEME" desc="Text of the label describing the system (GTK+) browser theme on Linux"> 253 <message name="IDS_SETTINGS_SYSTEM_THEME" desc="Text of the label describing the system (GTK+) browser theme on Linux">
251 GTK+ 254 GTK+
252 </message> 255 </message>
(...skipping 2692 matching lines...) Expand 10 before | Expand all | Expand 10 after
2945 System 2948 System
2946 </message> 2949 </message>
2947 <message name="IDS_SETTINGS_SYSTEM_HARDWARE_ACCELERATION_LABEL" desc="Label for the checkbox that forces Chrome to render via hardware acceleration (GPU) wh en available."> 2950 <message name="IDS_SETTINGS_SYSTEM_HARDWARE_ACCELERATION_LABEL" desc="Label for the checkbox that forces Chrome to render via hardware acceleration (GPU) wh en available.">
2948 Use hardware acceleration when available 2951 Use hardware acceleration when available
2949 </message> 2952 </message>
2950 <message name="IDS_SETTINGS_SYSTEM_PROXY_SETTINGS_BUTTON" desc="Text for the button that changes a user's network proxy settings."> 2953 <message name="IDS_SETTINGS_SYSTEM_PROXY_SETTINGS_BUTTON" desc="Text for the button that changes a user's network proxy settings.">
2951 Change proxy settings 2954 Change proxy settings
2952 </message> 2955 </message>
2953 </if> 2956 </if>
2954 </grit-part> 2957 </grit-part>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698