Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: fix formatting Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index f741a59b07b4c642e7488d0fc6ba9e3e1ba31871..bdc12b124a63d14fc328577ab3c66731c106f6f7 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -26,8 +26,14 @@
-webkit-margin-start: 12px;
}
+ #custom-input {
+ margin-bottom: 1rem;
+ }
+
#customHomePage {
- width: 200px;
+ --paper-input-container: {
+ width: 200px;
+ };
}
</style>
<settings-animated-pages id="pages" section="appearance">
@@ -112,17 +118,18 @@
pref="[[prefs.homepage_is_newtabpage]]"
label="$i18n{homePageNtp}" no-extension-indicator>
</controlled-radio-button>
- <controlled-radio-button class="list-item" name="false"
- pref="[[prefs.homepage_is_newtabpage]]"
+ <controlled-radio-button id="custom-input" class="list-item"
+ name="false" pref="[[prefs.homepage_is_newtabpage]]"
no-extension-indicator>
<!-- TODO(dbeam): this can show double indicators when both
homepage and whether to use the NTP as the homepage are
managed. -->
- <settings-input id="customHomePage"
- no-label-float pref="{{prefs.homepage}}"
+ <settings-input id="customHomePage" pref="{{prefs.homepage}}"
label="$i18n{enterCustomWebAddress}"
can-tab="[[!prefs.homepage_is_newtabpage.value]]"
- stop-keyboard-event-propagation no-extension-indicator>
+ no-extension-indicator
+ error-message="$i18n{notValid}"
+ on-input="validate_" invalid="{{isHomeUrlInvalid_}}">
</settings-input>
</controlled-radio-button>
<template is="dom-if" if="[[prefs.homepage.extensionId]]">

Powered by Google App Engine
This is Rietveld 408576698