Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4488)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: fix formatting Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
index b139a7f1494d8067d4e5b4245034d6308fa28ff1..65b7698028c9486cd875423cec6ad8f35d39ba92 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
@@ -28,6 +28,12 @@ cr.define('settings', function() {
// <if expr="is_linux and not chromeos">
useSystemTheme: assertNotReached,
// </if>
+
+ /**
+ * @param {string} url The url of which to check validity.
+ * @return {!Promise<boolean>}
+ */
+ validateStartupPage: assertNotReached,
};
/**
@@ -76,6 +82,11 @@ cr.define('settings', function() {
chrome.send('useSystemTheme');
},
// </if>
+
+ /** @override */
+ validateStartupPage: function(url) {
+ return cr.sendWithPromise('validateStartupPage', url);
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698