ios/shared/chrome/browser/tabs/web_state_list.mm - Issue 2766063002: Remove the concept of currentItemIndex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/shared/chrome/browser/tabs/web_state_list.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)

Patch Set: fix unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/shared/chrome/browser/tabs/web_state_list.mm

diff --git a/ios/shared/chrome/browser/tabs/web_state_list.mm b/ios/shared/chrome/browser/tabs/web_state_list.mm

index 5da7b0cd66abb6bab602d30ca66da5cf4e42b576..d4941fdfb04836d378e686ab0c7a39a9917d4a72 100644

--- a/ios/shared/chrome/browser/tabs/web_state_list.mm

+++ b/ios/shared/chrome/browser/tabs/web_state_list.mm

@@ -301,7 +301,8 @@ bool WasOpenedBy(const web::WebState* opener,

return kInvalidIndex;

const int opener_navigation_index =

- use_group ? opener->GetNavigationManager()->GetCurrentItemIndex() : -1;

+ use_group ? opener->GetNavigationManager()->GetLastCommittedItemIndex()

+ : -1;

int found_index = kInvalidIndex;

for (int index = start_index + 1; index < count() && n; ++index) {