ios/chrome/browser/web/navigation_manager_util.mm - Issue 2766063002: Remove the concept of currentItemIndex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/navigation_manager_util.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)

Patch Set: fix unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/navigation_manager_util.mm

diff --git a/ios/chrome/browser/web/navigation_manager_util.mm b/ios/chrome/browser/web/navigation_manager_util.mm

index 81a61b908a3971ec7cd750e68af3db88e026bd86..794c72a181cfe7683ae0840b15b76e3e208ab394 100644

--- a/ios/chrome/browser/web/navigation_manager_util.mm

+++ b/ios/chrome/browser/web/navigation_manager_util.mm

@@ -12,7 +12,7 @@

web::NavigationManager* nav_manager) {

if (!nav_manager || !nav_manager->GetItemCount())

return nullptr;

- int index = nav_manager->GetCurrentItemIndex();

+ int index = nav_manager->GetLastCommittedItemIndex();

web::NavigationItem* item = nullptr;

while (index >= 0) {

item = nav_manager->GetItemAtIndex(index);