[refactor] Fix autofill features for payments when the form is inside an OOPIF

content/renderer/render_frame_impl.h

Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 3ddeaae759779d0a030ea6d32150ba0dd81ed107..07531e457634f262cb9deaf6e942b3f361f2dada 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -249,6 +249,9 @@ class CONTENT_EXPORT RenderFrameImpl
   // Overwrites the given URL to use an HTML5 embed if possible.
   blink::WebURL overrideFlashEmbedWithHTML(const blink::WebURL& url) override;
 
+  void didCompleteLeftMouseDownOrGestureTapInNode(
+      const blink::WebNode& node) override;

[Charlie Reis, 2017/04/05 20:13:45]

This should be in the WebFrameClient overrides section around line 693 (as
should overrideFlashEmbedWithHTML).

[EhsanK, 2017/04/06 21:31:28]

Thanks. I moved both. Also deleted the comment above overrideFlasEmbedWithHTML
as exactly the first sentence in the comment for
WebFrameClient::overrideFlashEmbedWithHTML.

+
   ~RenderFrameImpl() override;
 
   // Called by RenderWidget when meaningful layout has happened.
@@ -265,6 +268,14 @@ class CONTENT_EXPORT RenderFrameImpl
   // Returns the unique name of the RenderFrame.
   const std::string& unique_name() const { return unique_name_helper_.value(); }
 
+  // Called by render widget to notify about a change in focused element.

[Charlie Reis, 2017/04/05 20:13:45]

nit: RenderWidget

Might want to clarify that this is called on every frame, if we stick with that
decision.

[EhsanK, 2017/04/06 21:31:28]

Done. Thanks!

+  void DidCompleteFocusChange();
+
+  // Called by render widget to notify about handling a left mouse down or

[Charlie Reis, 2017/04/05 20:13:45]

nit: RenderWidget

[EhsanK, 2017/04/06 21:31:28]

Done.

+  // gesture tap in |node|. |node| belongs to a frame inside the subtree rooted
+  // at the local root and is never null.

[Charlie Reis, 2017/04/05 20:13:45]

I'm not clear on this explanation.  Are you saying it's called on the local
root's RenderFrameImpl, and not on the frame |node| is in?  That's a bit
confusing (especially next to DidCompleteFocusChange, which is apparently called
on every frame), so it's worth clarifying.

[EhsanK, 2017/04/06 21:31:28]

Sorry about this code and comment. I forgot to remove this from previous patch.
The logic is now in WebFrameClient (RenderFrameImpl) and does not go to
WebWidgetClient and then to all RenderFrameImpls. Now we directly call
WebFrameClient::didCompleteLeftMouseDownOrGestureTapInNode().

+  void DidCompleteLeftMouseDownOrGestureTapInNode(const blink::WebNode& node);

[Charlie Reis, 2017/04/05 20:13:45]

This isn't implemented or called.  Is it stale code, or would compile or tests
have caught it?

[EhsanK, 2017/04/06 21:31:28]

Stale code from previous patch. Apologies. Thanks!

+
   // TODO(jam): this is a temporary getter until all the code is transitioned
   // to using RenderFrame instead of RenderView.
   RenderViewImpl* render_view() { return render_view_; }