[refactor] Fix autofill features for payments when the form is inside an OOPIF

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 906788e4b419dfc4a37a2666b8650178c88fde79..8280cccbad12b41a8cc1ef9260b04fa9c0f168b9 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1092,6 +1092,15 @@ blink::WebURL RenderFrameImpl::overrideFlashEmbedWithHTML(
   return GetContentClient()->renderer()->OverrideFlashEmbedWithHTML(url);
 }
 
+void RenderFrameImpl::didCompleteLeftMouseDownOrGestureTapInNode(

[Charlie Reis, 2017/04/05 20:13:44]

These should move down with the WebFrameClient overrides as well.

[EhsanK, 2017/04/06 21:31:28]

Done. Both for this method and the one above. Thanks!

+    const blink::WebNode& node) {
+  DCHECK(!node.isNull());
+  if (!frame_)
+    return;
+  for (auto& observer : observers_)
+    observer.DidCompleteLeftMouseDownOrGestureTapInNode(node);
+}
+
 // RenderFrameImpl ----------------------------------------------------------
 RenderFrameImpl::RenderFrameImpl(const CreateParams& params)
     : frame_(NULL),
@@ -2439,6 +2448,13 @@ void RenderFrameImpl::DidCommitAndDrawCompositorFrame() {
 #endif
 }
 
+void RenderFrameImpl::DidCompleteFocusChange() {
+  if (frame_ && frame_ == render_view_->webview()->focusedFrame()) {

[Charlie Reis, 2017/04/05 20:13:44]

Can these methods be called when frame_ is null?  Many of the methods in this
class just have a DCHECK(frame_).

(Also see my question in RenderWidget about whether we can only call this for
focused frames in the first place, possibly eliminating the need for this
check.)

[EhsanK, 2017/04/06 21:31:27]

You are right. WasHidden() only calls GetWebFrame() which contains a
DCHECK(frame_). This method is similar to that (i.e., called from RenderWidget
as observer call).
Yes that would eliminate the if block, but I guess coding-wise, that changes how
things have been layered so far, in that we would have to refer to RenderView
and RenderFrame from inside RenderWidget.

+    for (auto& observer : observers_)
+      observer.DidCompleteFocusChangeInFrame();
+  }
+}
+
 RenderView* RenderFrameImpl::GetRenderView() {
   return render_view_;
 }