Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2766053002: [refactor] Fix autofill features for payments when the form is inside an OOPIF (Closed)
Patch Set: Move a method from WebWidgetClient to WebFrameClient Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget_owner_delegate.h ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index cf15d6dd1d0e6dbf307d6ffaf2fd2589d005ffde..fb5000ddd1299aa6081ef4141456d88a08337f4d 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -1086,8 +1086,12 @@ void ChromeClientImpl::showUnhandledTapUIIfNeeded(
}
void ChromeClientImpl::onMouseDown(Node* mouseDownNode) {
- if (m_webView->client())
- m_webView->client()->onMouseDown(WebNode(mouseDownNode));
+ if (!mouseDownNode)
dcheng 2017/04/03 19:17:04 Can this actually be null?
EhsanK 2017/04/04 18:01:49 Thanks. Apparently it can't. Code search returns t
+ return;
+
+ WebLocalFrameImpl::fromFrame(mouseDownNode->document().frame())
+ ->client()
+ ->didCompleteLeftMouseDownOrGestureTapInNode(WebNode(mouseDownNode));
}
void ChromeClientImpl::handleKeyboardEventOnTextField(
« no previous file with comments | « content/renderer/render_widget_owner_delegate.h ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698