[refactor] Fix autofill features for payments when the form is inside an OOPIF

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1068 matching lines @@
 void ChromeClientImpl::showUnhandledTapUIIfNeeded(
     IntPoint tappedPositionInViewport,
     Node* tappedNode,
     bool pageChanged) {
   if (m_webView->client())
     m_webView->client()->showUnhandledTapUIIfNeeded(
         WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged);
 }
 
 void ChromeClientImpl::onMouseDown(Node* mouseDownNode) {
-  if (m_webView->client())
-    m_webView->client()->onMouseDown(WebNode(mouseDownNode));
+  if (!mouseDownNode)

[dcheng, 2017/04/03 19:17:04]

Can this actually be null?

[EhsanK, 2017/04/04 18:01:49]

Thanks. Apparently it can't. Code search returns the two calls to be from
EventHandler and GestureManager and in both cases we only call this method if
HitTestResult.innerNode() is not nullptr.

+    return;
+
+  WebLocalFrameImpl::fromFrame(mouseDownNode->document().frame())
+      ->client()
+      ->didCompleteLeftMouseDownOrGestureTapInNode(WebNode(mouseDownNode));
 }
 
 void ChromeClientImpl::handleKeyboardEventOnTextField(
     HTMLInputElement& inputElement,
     KeyboardEvent& event) {
   WebLocalFrameImpl* webframe =
       WebLocalFrameImpl::fromFrame(inputElement.document().frame());
   if (webframe->autofillClient())
     webframe->autofillClient()->textFieldDidReceiveKeyDown(

[dcheng, 2017/04/03 19:17:04]

It seems like this is plumbed through WebAutofillClient -- maybe we can do that
for the mouse down stuff too, since it's autofill specific?

[EhsanK, 2017/04/04 18:01:49]

This is a good suggestion. However, the call right now goes to PageClickTracker
and then through the PageClickListener interface to the AutofillAgent which so
happens to be the WebAutofillClient.

That being said, similarly, I could also add a method to WebAutofillClient for
FocusChangeComplete and then remove the PageClickTracker and PageClickListener
completely.  However, there is a bunch of tests involved and it takes some time.
I am happy to work on it, either in this CL or a followup one if vabr@ is also
happy with the change.

[dcheng, 2017/04/05 16:59:33]

vabr@, does this make sense to you?

[vabr (Chromium), 2017/04/10 06:48:27]

Indeed, this makes sense to me, based on this signal being autofill-specific.

[EhsanK, 2017/04/13 20:00:59]

So I will go ahead and work on the refactor within in this CL. Thanks!

         WebInputElement(&inputElement), WebKeyboardEventBuilder(event));
 }
 
 void ChromeClientImpl::didChangeValueInTextField(
     HTMLFormControlElement& element) {
   WebLocalFrameImpl* webframe =
       WebLocalFrameImpl::fromFrame(element.document().frame());
   if (webframe->autofillClient())
     webframe->autofillClient()->textFieldDidChange(
         WebFormControlElement(&element));
@@ skipping 113 matching lines @@
     PresentationController::provideTo(frame, client->presentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
     provideAudioOutputDeviceClientTo(frame,
                                      new AudioOutputDeviceClientImpl(frame));
   }
   if (RuntimeEnabledFeatures::installedAppEnabled())
     InstalledAppController::provideTo(frame, client->relatedAppsFetcher());
 }
 
 }  // namespace blink