Add DocumentMarker::createCompositionMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index 49c9508b0e8e2d60c5755b078091220122c99447..5b1c84e5d95b29f6fb221d69a5b043465f2ba0d5 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -91,16 +91,17 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
     SpellCheckClientMarkers() : MarkerTypes(Spelling | Grammar) {}
   };
 
+  static DocumentMarker* createCompositionMarker(unsigned startOffset,
+                                                 unsigned endOffset,
+                                                 Color underlineColor,
+                                                 bool thick,
+                                                 Color backgroundColor);
+
   DocumentMarker(MarkerType,
                  unsigned startOffset,
                  unsigned endOffset,
                  const String& description);
   DocumentMarker(unsigned startOffset, unsigned endOffset, bool activeMatch);
-  DocumentMarker(unsigned startOffset,
-                 unsigned endOffset,
-                 Color underlineColor,
-                 bool thick,
-                 Color backgroundColor);
 
   DocumentMarker(const DocumentMarker&);
 
@@ -145,6 +146,11 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
   DECLARE_TRACE();
 
  private:
+  DocumentMarker(MarkerType,

[yosin_UTC9, 2017/03/22 05:15:49]

It seems this change doesn't relate to introduce
DocumentMarker::createCompositionMarker()

[rlanday, 2017/03/22 18:25:15]

I need this private constructor to implement the create*Marker() methods. Do you
want this split off into a separate CL too? I feel like this is already small
enough.

[yosin_UTC9, 2017/03/23 06:04:39]

Yes, since this new constructor doesn't need for createCompositionMarker(), it
should be in another patch.
Isolation is another goal of making patch small in case of reverting and
bisecting.

+                 unsigned startOffset,
+                 unsigned endOffset,
+                 DocumentMarkerDetails*);
+
   MarkerType m_type;
   unsigned m_startOffset;
   unsigned m_endOffset;