Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2765993003: Merge SelectorDataList into SelectorQuery. (Closed)

Created:
3 years, 9 months ago by esprehn
Modified:
3 years, 9 months ago
Reviewers:
dglazkov, rune, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge SelectorDataList into SelectorQuery. Having a separate class doesn't really do anything here except mean we need proxy methods to call through to it. This patch merges the two classes and removes those proxy methods. I also made some methods into file level functions since they didn't use any instance data. Finally I added comments linking to the specs for each of the four query methods. This patch should have no behavioral changes. BUG=703900 Review-Url: https://codereview.chromium.org/2765993003 Cr-Commit-Position: refs/heads/master@{#458680} Committed: https://chromium.googlesource.com/chromium/src/+/2ea907e4d0ea17ae9bc9293694db1128f2237ddc

Patch Set 1 #

Patch Set 2 : std::move(oops) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -92 lines) Patch
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 2 chunks +15 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 14 chunks +36 lines, -57 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
esprehn
3 years, 9 months ago (2017-03-22 00:19:09 UTC) #4
dglazkov
lgtm
3 years, 9 months ago (2017-03-22 00:20:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765993003/20001
3 years, 9 months ago (2017-03-22 07:54:10 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 08:04:52 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ea907e4d0ea17ae9bc9293694db...

Powered by Google App Engine
This is Rietveld 408576698