Improve handling of complicated getters and setters.

Improve handling of complicated getters and setters.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/6f422b93fc2bf76cfc0f1bd29b590356ca3c42a1

[ahe, 2017-03-21 18:36:21]

ahe@google.com changed reviewers:
+ paulberry@google.com

[ahe, 2017-03-21 18:36:21]

The changes to rasta/static are because we run the code as well, rasta didn't do
that. Also, the code is now better than what rasta generated :-D

https://codereview.chromium.org/2765943002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2765943002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:100: if
(getterBuilder?.isInstanceMember ?? false) {
Consider cases like this:

class C {
  static get v => null;
  set v(x) {}
  get w => null;
  static set w(x) {}
}

main() {
  print(C.v);
  C.w = null;
}

Yikes!

[ahe, 2017-03-21 18:37:46]

Status files will follow shortly.

[Paul Berry, 2017-03-21 21:24:49]

lgtm

[ahe, 2017-03-22 09:48:49]

Description was changed from

==========
Improve handling of complicated getters and setters.
==========

to

==========
Improve handling of complicated getters and setters.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6f422b93fc2bf76cfc0f1bd29b590356ca3c42a1
==========

[ahe, 2017-03-22 09:48:51]

Committed patchset #2 (id:20001) manually as
6f422b93fc2bf76cfc0f1bd29b590356ca3c42a1 (presubmit successful).