Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2761173004: Implement dynamic and void as types exported by core library. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement dynamic and void as types exported by core library. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/d50bfcde539efdf36a63c26e789bb8c04de07d83

Patch Set 1 #

Patch Set 2 : Use TypeBuilder.bind. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -48 lines) Patch
M pkg/analyzer/lib/src/fasta/element_store.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/builder/builtin_type_builder.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/dynamic_type_builder.dart View 1 chunk +4 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 2 chunks +13 lines, -1 line 0 comments Download
A pkg/front_end/lib/src/fasta/builder/void_type_builder.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 4 chunks +6 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 4 chunks +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
See the discussion in https://github.com/dart-lang/sdk/issues/29125 Whether or not this is the right thing to do, ...
3 years, 9 months ago (2017-03-21 18:09:06 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-21 18:15:02 UTC) #3
ahe
3 years, 9 months ago (2017-03-22 09:24:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d50bfcde539efdf36a63c26e789bb8c04de07d83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698