Correctly reload URLs in web views if a native controller is displayed.

ios/web/web_state/ui/crw_web_controller.mm

Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index c15eb0c28b87b3c90437e3146c956e359006209b..185044c9733e2afdbb9ceb77a6f8bffd9c71f9d7 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -1980,7 +1980,9 @@ - (void)reloadInternal {
   // cancelled.
   _lastUserInteraction.reset();
   base::RecordAction(UserMetricsAction("Reload"));
-  if (_webView) {
+  if ([self shouldLoadURLInNativeView:self.currentNavItem->GetURL()]) {

[Olivier, 2017/03/21 17:50:26]

I think this won't handle the Reading List loading correctly as  self
shouldLoadURLInNativeView:self.currentNavItem->GetURL()] will be true but not
yet presented in a native item.

Is it possible to have both test ?
like 
if ([self shouldLoadURLInNativeView:self.currentNavItem->GetURL()] &&
self.nativeController) {
 ?

[kkhorimoto, 2017/03/21 17:59:46]

Ahh you're right, I didn't think that through; the reading lists will still go
through the CRWNativeContent |-reload| path.  Your suggestion would still have
the same effect because the ErrorPageContent will be non-nil, so it'd still
reload the error page.  My CL is an improvement in its current form, but it
won't actually help your bug.  I think it'd probably be best to land your chrome
layer workaround in addition to this CL.  If possible, we should intercept the
error message and display any available offline content immediately instead of
the ErrorPageContents; this will eliminate the need for calling |-reload| here
to begin with.

+    [self.nativeController reload];
+  } else {
     web::NavigationItem* transientItem =
         self.navigationManagerImpl->GetTransientItem();
     if (transientItem) {
@@ -1998,8 +2000,6 @@ - (void)reloadInternal {
       // TODO(eugenebut): revisit this for WKWebView.
       [self loadCurrentURL];
     }
-  } else {
-    [self.nativeController reload];
   }
 }