Correctly reload URLs in web views if a native controller is displayed.

ios/web/web_state/ui/crw_web_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
 
 #import <objc/runtime.h>
 #include <stddef.h>
@@ skipping 1962 matching lines @@
 
 // Reload either the web view or the native content depending on which is
 // displayed.
 - (void)reloadInternal {
   // Clear last user interaction.
   // TODO(crbug.com/546337): Move to after the load commits, in the subclass
   // implementation. This will be inaccurate if the reload fails or is
   // cancelled.
   _lastUserInteraction.reset();
   base::RecordAction(UserMetricsAction("Reload"));
-  if (_webView) {
+  if ([self shouldLoadURLInNativeView:self.currentNavItem->GetURL()]) {

[Olivier, 2017/03/21 17:50:26]

I think this won't handle the Reading List loading correctly as  self
shouldLoadURLInNativeView:self.currentNavItem->GetURL()] will be true but not
yet presented in a native item.

Is it possible to have both test ?
like 
if ([self shouldLoadURLInNativeView:self.currentNavItem->GetURL()] &&
self.nativeController) {
 ?

[kkhorimoto, 2017/03/21 17:59:46]

Ahh you're right, I didn't think that through; the reading lists will still go
through the CRWNativeContent |-reload| path.  Your suggestion would still have
the same effect because the ErrorPageContent will be non-nil, so it'd still
reload the error page.  My CL is an improvement in its current form, but it
won't actually help your bug.  I think it'd probably be best to land your chrome
layer workaround in addition to this CL.  If possible, we should intercept the
error message and display any available offline content immediately instead of
the ErrorPageContents; this will eliminate the need for calling |-reload| here
to begin with.

+    [self.nativeController reload];
+  } else {
     web::NavigationItem* transientItem =
         self.navigationManagerImpl->GetTransientItem();
     if (transientItem) {
       // If there's a transient item, a reload is considered a new navigation to
       // the transient item's URL (as on other platforms).
       NavigationManager::WebLoadParams reloadParams(transientItem->GetURL());
       reloadParams.transition_type = ui::PAGE_TRANSITION_RELOAD;
       reloadParams.extra_headers.reset(
           [transientItem->GetHttpRequestHeaders() copy]);
       [self loadWithParams:reloadParams];
     } else {
       // As with back and forward navigation, load the URL manually instead of
       // using the web view's reload. This ensures state processing and delegate
       // calls are consistent.
       // TODO(eugenebut): revisit this for WKWebView.
       [self loadCurrentURL];
     }
-  } else {
-    [self.nativeController reload];
   }
 }
 
 - (void)reload {
   [_delegate webWillReload];
   [self reloadInternal];
 }
 
 - (void)abortLoad {
   [_webView stopLoading];
@@ skipping 3062 matching lines @@
 - (void)simulateLoadRequestWithURL:(const GURL&)URL {
   _lastRegisteredRequestURL = URL;
   _loadPhase = web::LOAD_REQUESTED;
 }
 
 - (NSString*)referrerFromNavigationAction:(WKNavigationAction*)action {
   return [action.request valueForHTTPHeaderField:kReferrerHeaderName];
 }
 
 @end