ui/views/controls/button/label_button.cc - Issue 2765883004: Implement Harmony typography spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/label_button.cc

Issue 2765883004: Implement Harmony typography spec. (Closed)

Patch Set: respond to comments, but i bet MSVC does not like my static constexpr Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/label_button.cc

diff --git a/ui/views/controls/button/label_button.cc b/ui/views/controls/button/label_button.cc

index 70a2f10e09b05d2748f2d52d9871398c35868586..f15aa17ea4863a2133beb3957795f0bd9780962c 100644

--- a/ui/views/controls/button/label_button.cc

+++ b/ui/views/controls/button/label_button.cc

@@ -238,6 +238,7 @@ gfx::Size LabelButton::GetPreferredSize() const {

// Use a temporary label copy for sizing to avoid calculation side-effects.

Label label(GetText(), {label_->font_list()});

+ label.SetLineHeight(label_->line_height());

label.SetShadows(label_->shadows());

if (style_ == STYLE_BUTTON && PlatformStyle::kDefaultLabelButtonHasBoldFont) {