Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: ui/gfx/platform_font.h

Issue 2765883004: Implement Harmony typography spec. (Closed)
Patch Set: respond to comments, but i bet MSVC does not like my static constexpr Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/platform_font.h
diff --git a/ui/gfx/platform_font.h b/ui/gfx/platform_font.h
index 48e14cf99608ad0fb52cae9b2ef6b2763cb99f2f..20d622b310a5ce6fe333a3504bd3f3ffdc4a042d 100644
--- a/ui/gfx/platform_font.h
+++ b/ui/gfx/platform_font.h
@@ -21,6 +21,16 @@ struct FontRenderParams;
class GFX_EXPORT PlatformFont : public base::RefCounted<PlatformFont> {
public:
+// The size of the font returned by CreateDefault() on a "default" platform
+// configuration. This allows UI that wants to target a particular size of font
+// to obtain that size for the majority of users, while still compensating for a
+// user preference for a larger or smaller font.
+#if defined(OS_MACOSX)
+ static constexpr int kPopularDefaultFontSize = 13;
Peter Kasting 2017/04/06 06:17:07 Nit: I have no idea where the word "popular" in th
tapted 2017/04/06 09:11:10 heh, that was to try to distinguish it from "Creat
+#else
+ static constexpr int kPopularDefaultFontSize = 12;
+#endif
+
// Creates an appropriate PlatformFont implementation.
static PlatformFont* CreateDefault();
#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_IOS)
« no previous file with comments | « chrome/browser/ui/views/harmony/layout_delegate_unittest.cc ('k') | ui/views/controls/button/label_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698