[Gin] Add Arguments::GetHolderCreationContext()

[Gin] Add Arguments::GetHolderCreationContext()

Currently, in order to get at the creation context of the holder, one
has to do the following:
v8::Local<v8::Object> holder;
arguments->GetHolder(&holder);
v8::Local<v8::Context> context = holder->CreationContext();

This isn't terrible, but it's a little verbose when all we really want
is FunctionCallbackInfo::Holder::CreationContext(). Add a method to get
at it directly.

BUG=None

Review-Url: https://codereview.chromium.org/2765853004
Cr-Commit-Position: refs/heads/master@{#459251}
Committed: https://chromium.googlesource.com/chromium/src/+/d982fdfedc982d24055caff18bb07852116d5fda

[Devlin, 2017-03-21 23:01:57]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:03:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 23:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:13:16]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Devlin, 2017-03-22 00:06:46]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org

[Devlin, 2017-03-22 00:06:47]

Jeremy, WDYT of something like this to clean up all those GetHolder()
redundancies?  (If it seems sane + beneficial to you, I'll send it off to
Jochen)

[jbroman, 2017-03-22 17:44:37]

Seems sane to me. This corresponds to the notion of the "relevant realm" in DOM
specs, and is used widely in Blink. It seems reasonable that gin consumers are
likely to want the same at a glance.

[Devlin, 2017-03-22 18:02:57]

rdevlin.cronin@chromium.org changed reviewers:
+ jochen@chromium.org

[Devlin, 2017-03-22 18:02:58]

Jochen, mind taking a look?

[jochen (gone - plz use gerrit), 2017-03-23 15:51:42]

can you add a unit test for this?

otherwise, lgtm

[Devlin, 2017-03-23 19:57:47]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:58:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:00:53]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-03-23 22:08:45]

Patchset #2 (id:20001) has been deleted

[Devlin, 2017-03-23 22:09:00]

On 2017/03/23 15:51:42, jochen wrote:
> can you add a unit test for this?

Done.

[Devlin, 2017-03-23 22:09:45]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-03-23 22:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2765853004/#ps40001
(title: "Add test")

[commit-bot: I haz the power, 2017-03-23 22:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:17:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490306985038120,
"parent_rev": "aaee89102bcd2d5fbc90be61286297e391ef882a", "commit_rev":
"d982fdfedc982d24055caff18bb07852116d5fda"}

[commit-bot: I haz the power, 2017-03-23 22:18:57]

Description was changed from

==========
[Gin] Add Arguments::GetHolderCreationContext()

Currently, in order to get at the creation context of the holder, one
has to do the following:
v8::Local<v8::Object> holder;
arguments->GetHolder(&holder);
v8::Local<v8::Context> context = holder->CreationContext();

This isn't terrible, but it's a little verbose when all we really want
is FunctionCallbackInfo::Holder::CreationContext(). Add a method to get
at it directly.

BUG=None
==========

to

==========
[Gin] Add Arguments::GetHolderCreationContext()

Currently, in order to get at the creation context of the holder, one
has to do the following:
v8::Local<v8::Object> holder;
arguments->GetHolder(&holder);
v8::Local<v8::Context> context = holder->CreationContext();

This isn't terrible, but it's a little verbose when all we really want
is FunctionCallbackInfo::Holder::CreationContext(). Add a method to get
at it directly.

BUG=None

Review-Url: https://codereview.chromium.org/2765853004
Cr-Commit-Position: refs/heads/master@{#459251}
Committed:
https://chromium.googlesource.com/chromium/src/+/d982fdfedc982d24055caff18bb0...
==========

[commit-bot: I haz the power, 2017-03-23 22:18:58]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d982fdfedc982d24055caff18bb0...