Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2765843003:
MD Settings: change paper-button border-radius from 4px to 2px (Closed)
|
Created:
3 years, 9 months ago by Dan Beam Modified:
3 years, 9 months ago Reviewers:
tsergeant CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, scottchen Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: change paper-button border-radius from 4px to 2px
R=tsergeant@chromium.org
BUG=703974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
Review-Url: https://codereview.chromium.org/2765843003
Cr-Commit-Position: refs/heads/master@{#458645}
Committed: https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0afef83ce79fc
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 ========== to ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
clear your calendar, this might take a while
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
After much scrutiny, lgtm
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
Description was changed from ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true ==========
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490161021035080, "parent_rev":
"435f259b846ab4d674d11b6600da57b4de7a1d58", "commit_rev":
"68eb3eeedcf794f9d970aa0886d0afef83ce79fc"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true ========== to ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Review-Url: https://codereview.chromium.org/2765843003 Cr-Commit-Position: refs/heads/master@{#458645} Committed: https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0...
Message was sent while issue was closed.
On 2017/03/22 06:44:26, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0... dbeam@ I originally changed it from paper-button default (which is 3px) to 4px due to Alan's comment saying that it looks too acute. See: https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4... and https://screenshot.googleplex.com/dn4VS05oAzj.png <- the "1.5px" version in this screenshot is with border-radius: 3px. Do you know why originally 3px looks like 1.5px to Alan? anything to do with screen dpi?
Message was sent while issue was closed.
Description was changed from ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Review-Url: https://codereview.chromium.org/2765843003 Cr-Commit-Position: refs/heads/master@{#458645} Committed: https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0... ========== to ========== MD Settings: change paper-button border-radius from 4px to 2px R=tsergeant@chromium.org BUG=703974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Review-Url: https://codereview.chromium.org/2765843003 Cr-Commit-Position: refs/heads/master@{#458645} Committed: https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0... ==========
Message was sent while issue was closed.
On 2017/03/22 21:08:13, scottchen wrote: > On 2017/03/22 06:44:26, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/68eb3eeedcf794f9d970aa0886d0... > > dbeam@ I originally changed it from paper-button default (which is 3px) to 4px > due to Alan's comment saying that it looks too acute. > See: > https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4... > and > https://screenshot.googleplex.com/dn4VS05oAzj.png <- the "1.5px" version in this > screenshot is with border-radius: 3px. > > Do you know why originally 3px looks like 1.5px to Alan? anything to do with > screen dpi? I didn't know there was a default. If so, we should just use the default. I don't see a reason to tweak it just for this page. That makes no sense to me. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
