Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 276583003: Password bubble: Deal correctly with blacklist state changes. (Closed)

Created:
6 years, 7 months ago by Mike West
Modified:
6 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Password bubble: Deal correctly with blacklist state changes. If a user blacklists or unblacklists a site in a separate tab, we need to correctly update every other tab's state (consider the unlikely case of logging into the same site 8 times at the same time in separate tabs, or the slightly less unlikely case of changing status in chrome://settings/passwords while a login page is visible). This CL updates the observer logic to account for blacklist entries being added and removed from the PasswordStore, and updates the UI accordingly. --------------------------------------------------------------------------- This is a reland of r269244, which was reverted due to LSAN breakage. Original review at https://codereview.chromium.org/276683003/ --------------------------------------------------------------------------- BUG=261628 TBR=vabr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269583

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -3 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-09 14:25:32 UTC) #1
Mike West
TBRing you, Vaclav; this CL implements the ScopedVector change that we discussed. -mike
6 years, 7 months ago (2014-05-09 14:26:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/276583003/1
6 years, 7 months ago (2014-05-09 14:27:15 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-09 14:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/276583003/20001
6 years, 7 months ago (2014-05-09 14:34:10 UTC) #5
vabr (Chromium)
LGTM, thanks!
6 years, 7 months ago (2014-05-09 14:45:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 16:21:42 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:04:11 UTC) #8
Message was sent while issue was closed.
Change committed as 269583

Powered by Google App Engine
This is Rietveld 408576698