Password bubble: Deal correctly with blacklist state changes.

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
+#include "base/memory/scoped_vector.h"
+#include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 
 namespace content {
 class WebContents;
@@ skipping 70 matching lines @@
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // All previously stored credentials for a specific site. Set by
   // OnPasswordSubmitted(), OnPasswordAutofilled(), or
   // OnBlacklistBlockedAutofill(). Protected, not private, so we can mess with
   // the value in ManagePasswordsUIControllerMock.
   autofill::PasswordFormMap password_form_map_;
 
+  // We create copies of PasswordForm objects that come in via OnLoginsChanged()
+  // and store them in this vector as well as in |password_form_map_| to ensure
+  // that we destroy them correctly.
+  ScopedVector<autofill::PasswordForm> new_password_forms_;
+
   // The current state of the password manager. Protected so we can manipulate
   // the value in tests.
   password_manager::ui::State state_;
 
  private:
   friend class content::WebContentsUserData<ManagePasswordsUIController>;
 
   // Shows the password bubble without user interaction. The controller MUST
   // be in PENDING_PASSWORD_AND_BUBBLE_STATE.
   void ShowBubbleWithoutUserInteraction();
@@ skipping 21 matching lines @@
 
   // The origin of the form we're currently dealing with; we'll use this to
   // determine which PasswordStore changes we should care about when updating
   // |password_form_map_|.
   GURL origin_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_