Issue 2765793002: Fix integer overflow in unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2765793002: Fix integer overflow in unittest. (Closed)

Created:
3 years, 9 months ago by Michael K. (Yandex Team)

Modified:
3 years, 9 months ago

Reviewers:
danakj, gab

CC:
chromium-reviews, vmpstr+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix integer overflow in unittest. It was introduced in https://codereview.chromium.org/2558043007. BUG=703522

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	base/sys_info_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael K. (Yandex Team)

danakj@ or jab@ PTAL ( I'm sorry I don't know how I missed this :( ...

3 years, 9 months ago (2017-03-21 06:05:50 UTC) #3

gab

On 2017/03/21 13:46:44, gab wrote: > lgtm Why is this issue closed?

3 years, 9 months ago (2017-03-21 13:47:14 UTC) #5

Michael K. (Yandex Team)

3 years, 9 months ago (2017-03-21 13:49:48 UTC) #6

Message was sent while issue was closed.

On 2017/03/21 13:47:14, gab wrote:
> On 2017/03/21 13:46:44, gab wrote:
> > lgtm
> 
> Why is this issue closed?

Because the original CL was reverted by the sheriff:
https://codereview.chromium.org/2558043007
(This patchset was added to it)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages