Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2765773002: Adds KeyEvent::properties (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds KeyEvent::properties This allows for associating arbitrary data with KeyEvents. BUG=701815 TEST=covered by tests R=sadrul@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2765773002 Cr-Commit-Position: refs/heads/master@{#458512} Committed: https://chromium.googlesource.com/chromium/src/+/4ab9c69373de3ee6f2563f88ee6ea68531d00608

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M ui/events/event.h View 5 chunks +16 lines, -1 line 2 comments Download
M ui/events/event.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 1 chunk +0 lines, -14 lines 1 comment Download
M ui/events/mojo/event.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/mojo/event.typemap View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/mojo/latency_info.typemap View 1 chunk +11 lines, -3 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sky
https://codereview.chromium.org/2765773002/diff/1/ui/events/mojo/BUILD.gn File ui/events/mojo/BUILD.gn (left): https://codereview.chromium.org/2765773002/diff/1/ui/events/mojo/BUILD.gn#oldcode33 ui/events/mojo/BUILD.gn:33: source_set("struct_traits") { Ken says you shouldn't need a separate ...
3 years, 9 months ago (2017-03-21 03:32:22 UTC) #1
sadrul
lgtm https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h#newcode958 ui/events/event.h:958: std::unique_ptr<Properties> properties_; Should this be a base::Optional?
3 years, 9 months ago (2017-03-21 17:21:14 UTC) #6
sky
https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h#newcode958 ui/events/event.h:958: std::unique_ptr<Properties> properties_; On 2017/03/21 17:21:14, sadrul wrote: > Should ...
3 years, 9 months ago (2017-03-21 17:25:38 UTC) #7
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-21 19:13:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765773002/1
3 years, 9 months ago (2017-03-21 19:20:34 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:38:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ab9c69373de3ee6f2563f88ee6e...

Powered by Google App Engine
This is Rietveld 408576698