Adds KeyEvent::properties

Adds KeyEvent::properties

This allows for associating arbitrary data with KeyEvents.

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2765773002
Cr-Commit-Position: refs/heads/master@{#458512}
Committed: https://chromium.googlesource.com/chromium/src/+/4ab9c69373de3ee6f2563f88ee6ea68531d00608

[sky, 2017-03-21 03:32:22]

https://codereview.chromium.org/2765773002/diff/1/ui/events/mojo/BUILD.gn
File ui/events/mojo/BUILD.gn (left):

https://codereview.chromium.org/2765773002/diff/1/ui/events/mojo/BUILD.gn#old...
ui/events/mojo/BUILD.gn:33: source_set("struct_traits") {
Ken says you shouldn't need a separate target for struct_Traits, rather they are
pulled in as part of the interfaces target.

[sky, 2017-03-21 03:32:28]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:32:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 04:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 04:32:15]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-21 17:21:14]

lgtm

https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h#newcode958
ui/events/event.h:958: std::unique_ptr<Properties> properties_;
Should this be a base::Optional?

[sky, 2017-03-21 17:25:38]

https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2765773002/diff/1/ui/events/event.h#newcode958
ui/events/event.h:958: std::unique_ptr<Properties> properties_;
On 2017/03/21 17:21:14, sadrul wrote:
> Should this be a base::Optional?

My understanding is that base::Optional's size is always that of the element,
where as unique_ptr size is that of the pointer value. As most KeyEvents won't
contain properties I went with unique_ptr.

[Tom Sepez, 2017-03-21 19:13:17]

lgtm

[sky, 2017-03-21 19:19:37]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:20:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490123977818450, "parent_rev":
"5ab1647cbaef5a6a8b76e7cb4ce1ab31c497b3d7", "commit_rev":
"4ab9c69373de3ee6f2563f88ee6ea68531d00608"}

[commit-bot: I haz the power, 2017-03-21 19:38:01]

Description was changed from

==========
Adds KeyEvent::properties

This allows for associating arbitrary data with KeyEvents.

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org, tsepez@chromium.org
==========

to

==========
Adds KeyEvent::properties

This allows for associating arbitrary data with KeyEvents.

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2765773002
Cr-Commit-Position: refs/heads/master@{#458512}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ab9c69373de3ee6f2563f88ee6e...
==========

[commit-bot: I haz the power, 2017-03-21 19:38:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ab9c69373de3ee6f2563f88ee6e...