Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2765763003: Fix the flaky Warmup URL test in data reduction proxy (Closed)

Created:
3 years, 9 months ago by tbansal1
Modified:
3 years, 9 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the flaky Warmup URL test in data reduction proxy Remove the part of the test that waits for the fetch to succeed. The test is flaking because sometimes the URL may be fetched before the callback is set. This causes the run loop to wait forever. BUG=702748 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2765763003 Cr-Commit-Position: refs/heads/master@{#458917} Committed: https://chromium.googlesource.com/chromium/src/+/dfc3e7204e434185cbaa0d6cb48ae0b37481f007

Patch Set 1 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 6 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 9 months ago (2017-03-21 16:49:34 UTC) #12
RyanSturm
lgtm
3 years, 9 months ago (2017-03-22 21:52:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765763003/40001
3 years, 9 months ago (2017-03-22 21:54:47 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 23:09:16 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dfc3e7204e434185cbaa0d6cb48a...

Powered by Google App Engine
This is Rietveld 408576698