Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1091)

Issue 2765733002: Rename Android Java pageinfo folder to page_info (matching other platforms). (Closed)

Created:
3 years, 2 months ago by lgarron
Modified:
3 years, 2 months ago
Reviewers:
Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews, gogerald+paymentswatch_chromium.org, jdonnelly+watch_chromium.org, lgarron+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, mahmadi+paymentswatch_chromium.org, raymes+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tsergeant
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Android Java pageinfo folder to page_info (matching other platforms). Also includes `git cl format`, per the presubmit. BUG=571533, 661796 Review-Url: https://codereview.chromium.org/2765733002 Cr-Commit-Position: refs/heads/master@{#458484} Committed: https://chromium.googlesource.com/chromium/src/+/3428b2d3e81169a97f933c7631b8194baf43d66b

Patch Set 1 #

Patch Set 2 : Rename Android Java pageinfo folder to page_info (matching other platforms). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1534 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/website_settings.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/page_info/CertificateChainHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/page_info/CertificateViewer.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/page_info/WebsiteSettingsPopup.java View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/pageinfo/CertificateChainHelper.java View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/pageinfo/CertificateViewer.java View 1 chunk +0 lines, -265 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java View 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +0 lines, -980 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/page_info/website_settings.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
lgarron
tsergeant@: Could you suggest an appropriate reviewer for this?
3 years, 2 months ago (2017-03-21 02:49:08 UTC) #9
tsergeant
+tedchoc@, who used to do my pageinfo reviews.
3 years, 2 months ago (2017-03-21 02:59:12 UTC) #11
Ted C
lgtm
3 years, 2 months ago (2017-03-21 16:07:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765733002/20001
3 years, 2 months ago (2017-03-21 18:23:15 UTC) #18
commit-bot: I haz the power
3 years, 2 months ago (2017-03-21 18:36:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3428b2d3e81169a97f933c7631b8...

Powered by Google App Engine
This is Rietveld 408576698