Remove deprecated extension notification from content_settings

remove deprecated extension notification from content_settings.

Use ExtensionRegistryObserver instead.

R=bauerb@chromium.org
BUG=354046, 354458
TEST=unit_tests

Committed: https://crrev.com/76ad58487578183de69a8caeb48b8a22dccad652
Cr-Commit-Position: refs/heads/master@{#294768}

[limasdf, 2014-05-13 15:38:34]

please take a look when you have time.

[Bernhard Bauer, 2014-05-13 15:46:23]

LGTM, thanks!

[limasdf, 2014-05-13 15:51:41]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-13 15:52:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/276573011/20001

[commit-bot: I haz the power, 2014-05-13 19:56:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-13 21:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 21:23:25]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[limasdf, 2014-06-10 08:53:49]

Bernhard, Could you take a look again?
This fixes unit_tests.(Remove observer when ExtensionRegistry shutdown first).

[Bernhard Bauer, 2014-06-10 08:57:05]

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:43:
extension_registry_ = extensions::ExtensionRegistry::Get(profile);
Could you initialize this in the initializer list above?

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:88:
if (extension_registry_) {
When can it happen that |extension_registry_| is NULL?

[limasdf, 2014-06-10 09:29:51]

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:43:
extension_registry_ = extensions::ExtensionRegistry::Get(profile);
On 2014/06/10 08:57:05, Bernhard Bauer wrote:
> Could you initialize this in the initializer list above?

Done.

https://codereview.chromium.org/276573011/diff/60001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:88:
if (extension_registry_) {
On 2014/06/10 08:57:05, Bernhard Bauer wrote:
> When can it happen that |extension_registry_| is NULL?

Hm, it seems doesn't necessary. Removed if statement.

[Bernhard Bauer, 2014-06-10 09:34:16]

lgtm

https://codereview.chromium.org/276573011/diff/80001/chrome/browser/content_s...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.h
(right):

https://codereview.chromium.org/276573011/diff/80001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.h:9:
#include "base/scoped_observer.h"
This isn't necessary anymore.

[limasdf, 2014-06-10 09:37:17]

Thank you for the review!

https://codereview.chromium.org/276573011/diff/80001/chrome/browser/content_s...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.h
(right):

https://codereview.chromium.org/276573011/diff/80001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.h:9:
#include "base/scoped_observer.h"
On 2014/06/10 09:34:16, Bernhard Bauer wrote:
> This isn't necessary anymore.

Done.

[limasdf, 2014-06-10 09:37:46]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-06-10 09:40:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/276573011/100001

[commit-bot: I haz the power, 2014-06-10 14:52:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-10 16:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 16:09:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[limasdf, 2014-09-14 05:51:29]

Patchset #6 (id:180001) has been deleted

[limasdf, 2014-09-14 05:51:40]

Patchset #6 (id:200001) has been deleted

[limasdf, 2014-09-14 05:51:51]

Patchset #5 (id:160001) has been deleted

[limasdf, 2014-09-14 06:22:11]

Sorry to bother you again. 
This finally seems to fix.
PTAL

[Bernhard Bauer, 2014-09-14 14:04:05]

LGTM, just one nit:

https://codereview.chromium.org/276573011/diff/220001/chrome/browser/content_...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/276573011/diff/220001/chrome/browser/content_...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:75:
DCHECK_EQ(type, extensions::NOTIFICATION_EXTENSION_HOST_CREATED);
Nit: Put the expected value first for a more informative error message on
failure.

[limasdf, 2014-09-14 14:08:52]

Thank you for the review

https://codereview.chromium.org/276573011/diff/220001/chrome/browser/content_...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/276573011/diff/220001/chrome/browser/content_...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:75:
DCHECK_EQ(type, extensions::NOTIFICATION_EXTENSION_HOST_CREATED);
On 2014/09/14 14:04:04, Bernhard Bauer wrote:
> Nit: Put the expected value first for a more informative error message on
> failure.

Done.

[limasdf, 2014-09-14 14:08:58]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-09-14 14:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/276573011/240001

[commit-bot: I haz the power, 2014-09-14 16:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-14 16:10:17]

Exceeded time limit waiting for builds to trigger.

[limasdf, 2014-09-14 17:03:59]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-09-14 17:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/276573011/240001

[commit-bot: I haz the power, 2014-09-14 18:32:35]

Committed patchset #6 (id:240001) as 31a96f8898f73bd7decd56c02aa0dff5877852a6

[commit-bot: I haz the power, 2014-09-14 18:35:57]

Patchset 6 (id:??) landed as
https://crrev.com/76ad58487578183de69a8caeb48b8a22dccad652
Cr-Commit-Position: refs/heads/master@{#294768}

[limasdf, 2014-09-15 00:21:09]

A revert of this CL (patchset #6 id:240001) has been created in
https://codereview.chromium.org/553263004/ by limasdf@gmail.com.

The reason for reverting is: Becuase this CL seems to break linux asan test
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....

[tapted, 2014-09-15 01:18:39]

https://codereview.chromium.org/276573011/diff/240001/chrome/browser/content_...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.h
(right):

https://codereview.chromium.org/276573011/diff/240001/chrome/browser/content_...
chrome/browser/content_settings/content_settings_internal_extension_provider.h:81:
extensions::ExtensionRegistry* extension_registry_;  // Not owned.
This extra state might not be necessary once
https://codereview.chromium.org/556173002/ lands. (waiting for that CL might
even help with the asan issue too)