Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2765713003: PPC: Use correct register to store returned instr (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Use correct register to store returned instr ip gets modified when FrameAndConstantPoolScope scope ends. Using another register to store the start of the returned instr. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2765713003 Cr-Commit-Position: refs/heads/master@{#43999} Committed: https://chromium.googlesource.com/v8/v8/+/7e0c03f593ca2098a105fd3515f961fba53ad5c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-21 20:11:09 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-21 21:59:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765713003/1
3 years, 9 months ago (2017-03-21 23:20:16 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 23:40:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7e0c03f593ca2098a105fd3515f961fba53...

Powered by Google App Engine
This is Rietveld 408576698