Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2765633002: Plugin Power Saver Tiny: Treat completely obscured plugins as Tiny. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by tommycli
Modified:
2 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver Tiny: Treat completely obscured plugins as Tiny. Previously we can considered 0x0 (completely obscured) plugins as essential, out of an abundance of caution. Now we are marking these as Tiny. BUG=703404 Review-Url: https://codereview.chromium.org/2765633002 Cr-Commit-Position: refs/heads/master@{#458455} Committed: https://chromium.googlesource.com/chromium/src/+/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/plugin_power_saver/block_tiny_plugins.html View 1 chunk +7 lines, -0 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/peripheral_content_heuristic.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/peripheral_content_heuristic_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
tommycli
piman: PTAL, thanks!
2 months ago (2017-03-20 23:13:17 UTC) #3
piman
lgtm
2 months ago (2017-03-20 23:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765633002/1
2 months ago (2017-03-21 16:45:53 UTC) #9
commit-bot: I haz the power
2 months ago (2017-03-21 17:29:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5fe8f12bcaf5b03b0bdbf5afb73...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06