Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2765593002: gpu/config: Use angle::GetSystemInfo on Mac (Closed)

Created:
3 years, 9 months ago by Corentin Wallez
Modified:
3 years, 9 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, mac-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/config: Use angle::GetSystemInfo on Mac BUG=angleproject:1874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2765593002 Cr-Commit-Position: refs/heads/master@{#459142} Committed: https://chromium.googlesource.com/chromium/src/+/3d3f72ef6f9a4f0bfd887878288bb2f3296cd005

Patch Set 1 #

Patch Set 2 : gpu/config: Use angle::GetSystemInfo on Mac #

Patch Set 3 : gpu/config: Use angle::GetSystemInfo on Mac #

Patch Set 4 : gpu/config: Use angle::GetSystemInfo on Mac #

Patch Set 5 : gpu/config: Use angle::GetSystemInfo on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -196 lines) Patch
M gpu/config/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M gpu/config/gpu_info_collector_mac.mm View 2 chunks +9 lines, -173 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
Corentin Wallez
Finally got this to work, PTAL!
3 years, 9 months ago (2017-03-23 16:36:43 UTC) #17
Zhenyao Mo
On 2017/03/23 16:36:43, Corentin Wallez wrote: > Finally got this to work, PTAL! lgtm
3 years, 9 months ago (2017-03-23 16:53:55 UTC) #20
Corentin Wallez
Thanks!
3 years, 9 months ago (2017-03-23 16:58:23 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765593002/80001
3 years, 9 months ago (2017-03-23 16:58:54 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 18:07:25 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3d3f72ef6f9a4f0bfd887878288b...

Powered by Google App Engine
This is Rietveld 408576698