Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2765533002: Merges the |kHTML| and |kScreenReader| AccessibilityModes on Windows. (Closed)

Created:
3 years, 9 months ago by nektarios
Modified:
3 years, 9 months ago
Reviewers:
aleventhal, dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merges the |kHTML| and |kScreenReader| AccessibilityModes on Windows. Unfortunately there is no easy way to separate the HTML and ScreenReader accessibility modes on Windows. HTML mode includes HTML tag name, HTML attributes and inner HTML for math tags. However, screen readers rely on some of the above for correct functioning: For example, the HTML tag name is used in some IA2 roles. Input fields expose their type attribute. Unless we create a new EnhancedScreenReader mode only for Windows, it's hard to separate the two existing modes. BUG=703277 R=dmazzoni@chromium.org, aleventhal@chromium.org Review-Url: https://codereview.chromium.org/2765533002 Cr-Commit-Position: refs/heads/master@{#458440} Committed: https://chromium.googlesource.com/chromium/src/+/20bfdecc5f865755ad8b8a18fdc9fd3bac161fca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -105 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 99 chunks +113 lines, -105 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nektarios
3 years, 9 months ago (2017-03-20 18:32:28 UTC) #1
dmazzoni
lgtm
3 years, 9 months ago (2017-03-21 16:04:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765533002/1
3 years, 9 months ago (2017-03-21 16:04:41 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:54:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20bfdecc5f865755ad8b8a18fdc9...

Powered by Google App Engine
This is Rietveld 408576698