arc: Add explicit error message in case network cannot be setup.

arc: Add explicit error message in case network cannot be setup.

Once we are fixing another opt-in failure reasons, this one becomes
more frequent and it is good to have explicit error for this.

BUG=b/36446420
TEST=Manually, emulating this error.

Review-Url: https://codereview.chromium.org/2765523002
Cr-Commit-Position: refs/heads/master@{#458581}
Committed: https://chromium.googlesource.com/chromium/src/+/8ac7568e9ff6ed8866a547e930b2e7349324c34e

[khmel, 2017-03-20 18:07:10]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2017-03-20 18:18:31]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:19:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:10:08]

Dry run: This issue passed the CQ dry run.

[khmel, 2017-03-21 20:00:56]

khmel@chromium.org changed reviewers:
+ lhchavez@chromium.org

[khmel, 2017-03-21 20:00:57]

Hi Luis,

PTAL

Thanks

[Luis Héctor Chávez, 2017-03-21 21:10:30]

do you want to merge this to any branch? If so, you need to replace the bug with
a crbug.com bug.

[khmel, 2017-03-21 21:12:43]

On 2017/03/21 21:10:30, Luis Héctor Chávez wrote:
> do you want to merge this to any branch? If so, you need to replace the bug
with
> a http://crbug.com bug.

Thanks for reminding! I am planning to have it in master branch only (M59 is
fine, should be enough). Also we are limited in bringing the new text into beta
branches (m58) IIUC.

[Luis Héctor Chávez, 2017-03-21 21:22:23]

lgtm with a nit in that case.

https://codereview.chromium.org/2765523002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_support_host.h (right):

https://codereview.chromium.org/2765523002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_support_host.h:36: SIGN_IN_NETWORK_ERROR,
nit: Can these be sorted lexicographically?

[khmel, 2017-03-21 21:31:41]

https://codereview.chromium.org/2765523002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_support_host.h (right):

https://codereview.chromium.org/2765523002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_support_host.h:36: SIGN_IN_NETWORK_ERROR,
On 2017/03/21 21:22:22, Luis Héctor Chávez wrote:
> nit: Can these be sorted lexicographically?

Good point, thanks for review!

[khmel, 2017-03-21 21:31:58]

The CQ bit was checked by khmel@chromium.org

[khmel, 2017-03-21 21:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2765523002/#ps40001
(title: "sort enums")

[commit-bot: I haz the power, 2017-03-21 21:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 22:21:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490131918289490,
"parent_rev": "25f0fa80874f1f91402aa3de3fbb9738d03e05e6", "commit_rev":
"8ac7568e9ff6ed8866a547e930b2e7349324c34e"}

[commit-bot: I haz the power, 2017-03-21 22:22:26]

Description was changed from

==========
arc: Add explicit error message in case network cannot be setup.

Once we are fixing another opt-in failure reasons, this one becomes
more frequent and it is good to have explicit error for this.

BUG=b/36446420
TEST=Manually, emulating this error.
==========

to

==========
arc: Add explicit error message in case network cannot be setup.

Once we are fixing another opt-in failure reasons, this one becomes
more frequent and it is good to have explicit error for this.

BUG=b/36446420
TEST=Manually, emulating this error.

Review-Url: https://codereview.chromium.org/2765523002
Cr-Commit-Position: refs/heads/master@{#458581}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ac7568e9ff6ed8866a547e930b2...
==========

[commit-bot: I haz the power, 2017-03-21 22:22:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ac7568e9ff6ed8866a547e930b2...