Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/resources/extensions/extensions.js

Issue 2765493002: Fixing accessibility bug with extensions preferences (Closed)
Patch Set: Reverted back to aria-hidden version. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // <include src="../../../../ui/webui/resources/js/cr/ui/focus_row.js"> 5 // <include src="../../../../ui/webui/resources/js/cr/ui/focus_row.js">
6 // <include src="../../../../ui/webui/resources/js/cr/ui/focus_grid.js"> 6 // <include src="../../../../ui/webui/resources/js/cr/ui/focus_grid.js">
7 // <include src="../uber/uber_utils.js"> 7 // <include src="../uber/uber_utils.js">
8 // <include src="drag_and_drop_handler.js"> 8 // <include src="drag_and_drop_handler.js">
9 // <include src="extension_code.js"> 9 // <include src="extension_code.js">
10 // <include src="extension_commands_overlay.js"> 10 // <include src="extension_commands_overlay.js">
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 lastFocused.focus(); 385 lastFocused.focus();
386 386
387 $('overlay').removeEventListener('cancelOverlay', f); 387 $('overlay').removeEventListener('cancelOverlay', f);
388 uber.replaceState({}, ''); 388 uber.replaceState({}, '');
389 }); 389 });
390 node.classList.add('showing'); 390 node.classList.add('showing');
391 } 391 }
392 392
393 var pages = document.querySelectorAll('.page'); 393 var pages = document.querySelectorAll('.page');
394 for (var i = 0; i < pages.length; i++) { 394 for (var i = 0; i < pages.length; i++) {
395 pages[i].setAttribute('aria-hidden', node ? 'true' : 'false'); 395 var hidden = (node != pages[i]) ? 'true' : 'false';
396 pages[i].setAttribute('aria-hidden', hidden);
396 } 397 }
397 398
398 $('overlay').hidden = !node; 399 $('overlay').hidden = !node;
399 400
400 if (node) 401 if (node)
401 ExtensionSettings.focusOverlay(); 402 ExtensionSettings.focusOverlay();
402 403
403 // If drag-drop for external Extension installation is available, enable 404 // If drag-drop for external Extension installation is available, enable
404 // drag-drop when there is any overlay showing other than the usual overlay 405 // drag-drop when there is any overlay showing other than the usual overlay
405 // shown when drag-drop is started. 406 // shown when drag-drop is started.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 462
462 // Export 463 // Export
463 return { 464 return {
464 ExtensionSettings: ExtensionSettings 465 ExtensionSettings: ExtensionSettings
465 }; 466 };
466 }); 467 });
467 468
468 window.addEventListener('load', function(e) { 469 window.addEventListener('load', function(e) {
469 extensions.ExtensionSettings.getInstance().initialize(); 470 extensions.ExtensionSettings.getInstance().initialize();
470 }); 471 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698