Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 2765493002: Fixing accessibility bug with extensions preferences (Closed)
Patch Set: Reverted back to aria-hidden version. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(dbeam): test for loading upacked extensions? 5 // TODO(dbeam): test for loading upacked extensions?
6 6
7 GEN('#include "chrome/browser/ui/webui/extensions/' + 7 GEN('#include "chrome/browser/ui/webui/extensions/' +
8 'extension_settings_browsertest.h"'); 8 'extension_settings_browsertest.h"');
9 9
10 // The id of the extension from |InstallGoodExtension|. 10 // The id of the extension from |InstallGoodExtension|.
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 * @const 399 * @const
400 */ 400 */
401 browsePreload: 'chrome://extensions-frame/configureCommands', 401 browsePreload: 'chrome://extensions-frame/configureCommands',
402 }; 402 };
403 403
404 TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'testChromeSendHandler', 404 TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'testChromeSendHandler',
405 function() { 405 function() {
406 // Just navigating to the page should trigger the chrome.send(). 406 // Just navigating to the page should trigger the chrome.send().
407 var assertOverlayVisible = function() { 407 var assertOverlayVisible = function() {
408 assertTrue($('extension-commands-overlay').classList.contains('showing')); 408 assertTrue($('extension-commands-overlay').classList.contains('showing'));
409 assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
410 'false');
409 this.nextStep(); 411 this.nextStep();
410 }; 412 };
411 413
412 this.steps = [this.waitForPageLoad, assertOverlayVisible, testDone]; 414 this.steps = [this.waitForPageLoad, assertOverlayVisible, testDone];
413 this.nextStep(); 415 this.nextStep();
414 }); 416 });
415 417
416 TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri', 418 TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri',
417 function() { 419 function() {
418 var closeCommandOverlay = function() { 420 var closeCommandOverlay = function() {
419 assertTrue($('extension-commands-overlay').classList.contains('showing')); 421 assertTrue($('extension-commands-overlay').classList.contains('showing'));
422 assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
423 'false');
420 assertEquals(window.location.href, 424 assertEquals(window.location.href,
421 'chrome://extensions-frame/configureCommands'); 425 'chrome://extensions-frame/configureCommands');
422 426
423 // Close command overlay. 427 // Close command overlay.
424 $('extension-commands-dismiss').click(); 428 $('extension-commands-dismiss').click();
425 429
426 assertFalse($('extension-commands-overlay').classList.contains('showing')); 430 assertFalse($('extension-commands-overlay').classList.contains('showing'));
431 assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
432 'true');
427 this.nextStep(); 433 this.nextStep();
428 }; 434 };
429 435
430 var checkExtensionsUrl = function() { 436 var checkExtensionsUrl = function() {
431 // After closing the overlay, the URL shouldn't include commands overlay 437 // After closing the overlay, the URL shouldn't include commands overlay
432 // reference. 438 // reference.
433 assertEquals(window.location.href, 'chrome://extensions-frame/'); 439 assertEquals(window.location.href, 'chrome://extensions-frame/');
434 this.nextStep(); 440 this.nextStep();
435 }; 441 };
436 442
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 518
513 /** @override */ 519 /** @override */
514 browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload + 520 browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
515 '?options=' + GOOD_EXTENSION_ID, 521 '?options=' + GOOD_EXTENSION_ID,
516 }; 522 };
517 523
518 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility', 524 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility',
519 function() { 525 function() {
520 this.emptyTestForAccessibility(); 526 this.emptyTestForAccessibility();
521 }); 527 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698