Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2765463002: Remote fetch device status (attributes and logs) command (Closed)

1 year, 2 months ago by Ivan Šandrk
1 year, 2 months ago
Target Ref:


Remote fetch device status (attributes and logs) command This CL introduces a remote command that enables device administrators to remotely fetch device status (attributes and logs). Attributes were being uploaded every 3 hours and logs every 12 hours from the device side, and there was no way to trigger a remote refresh. More context can be found by reading the design doc go/remote-audio-management The new functionality was manually tested; remote reboot command was hijacked and rewired to decode into this command and then on the server side (CPanel admin) I clicked on "REBOOT NOW" and I observed the device attributes and logs being updated. P.S. I've also fixed up some linter errors. BUG=686389 TEST=Manually tested new behaviour. Review-Url: Cr-Commit-Position: refs/heads/master@{#459037} Committed:

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed comment, added bool guard #

Patch Set 3 : Missed one place for bool guard #

Patch Set 4 : Also added log fetching to command #

Total comments: 8

Patch Set 5 : Addressed Drew's comments, treating StatusUploader and SystemLogUploader as one #


Total messages: 39 (30 generated)
Ivan Šandrk
Hey Drew, please take a look! I'm unsure about how I handled the code around ...
1 year, 2 months ago (2017-03-20 15:09:13 UTC) #4
Andrew T Wilson (Slow) File chrome/browser/chromeos/policy/ (right): chrome/browser/chromeos/policy/ upload_callback_.Reset(base::Bind(&StatusUploader::UploadStatus, My main concern here is that we could ...
1 year, 2 months ago (2017-03-20 16:33:11 UTC) #8
Ivan Šandrk
ptal File chrome/browser/chromeos/policy/ (right): chrome/browser/chromeos/policy/ upload_callback_.Reset(base::Bind(&StatusUploader::UploadStatus, On 2017/03/20 16:33:10, Andrew T Wilson (Slow) ...
1 year, 2 months ago (2017-03-20 17:48:53 UTC) #11
Ivan Šandrk
Hey Drew ptal! Now it's fetching both attrs & logs.
1 year, 2 months ago (2017-03-21 17:17:02 UTC) #25
Andrew T Wilson (Slow)
PTAL if you address my comments below (esp logic around when to fail the remote ...
1 year, 2 months ago (2017-03-21 18:03:42 UTC) #26
Ivan Šandrk
Ptal :) File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h (right): chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:121: SystemLogUploader* GetSysLogUploader() const { On 2017/03/21 18:03:42, ...
1 year, 2 months ago (2017-03-22 20:20:02 UTC) #31
Andrew T Wilson (Slow)
1 year, 2 months ago (2017-03-23 10:03:57 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at
1 year, 2 months ago (2017-03-23 10:07:21 UTC) #36
commit-bot: I haz the power
1 year, 2 months ago (2017-03-23 10:11:55 UTC) #39
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as

Powered by Google App Engine
This is Rietveld 408576698