Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: gpu/ipc/common/gpu_surface_tracker.h

Issue 2765443004: AndroidOverlay implementation using Dialog. (Closed)
Patch Set: fixed gn Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/common/gpu_surface_tracker.h
diff --git a/gpu/ipc/common/gpu_surface_tracker.h b/gpu/ipc/common/gpu_surface_tracker.h
index 6d372712521397e6e77bd9d9160d1e7888dbfdcd..4aa926bf11209bd644165516ce44c5cae624c060 100644
--- a/gpu/ipc/common/gpu_surface_tracker.h
+++ b/gpu/ipc/common/gpu_surface_tracker.h
@@ -39,7 +39,12 @@ class GPU_EXPORT GpuSurfaceTracker : public gpu::GpuSurfaceLookup {
gpu::SurfaceHandle surface_handle) override;
#if defined(OS_ANDROID)
+ // Register |j_surface| with ID |surface_id|, which must be not in use.
void RegisterViewSurface(int surface_id, jobject j_surface);
+
+ // Register |j_surface| with a new surface ID and return the ID.
+ int RegisterViewSurface(jobject j_surface);
boliu 2017/03/30 22:42:02 err, I asked this to be refactored when this code
liberato (no reviews please) 2017/04/04 17:49:28 sorry about that. will refactor per our offline d
boliu 2017/04/04 23:53:21 Oh I originally asked someone else, not you Thank
+
void UnregisterViewSurface(int surface_id);
gl::ScopedJavaSurface AcquireJavaSurface(int surface_id) override;
#endif

Powered by Google App Engine
This is Rietveld 408576698