AndroidOverlay implementation using Dialog.

gpu/ipc/common/gpu_surface_tracker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_
 #define GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 21 matching lines @@
 // This class is thread safe.
 class GPU_EXPORT GpuSurfaceTracker : public gpu::GpuSurfaceLookup {
  public:
   // GpuSurfaceLookup implementation:
   // Returns the native widget associated with a given surface_handle.
   // On Android, this adds a reference on the ANativeWindow.
   gfx::AcceleratedWidget AcquireNativeWidget(
       gpu::SurfaceHandle surface_handle) override;
 
 #if defined(OS_ANDROID)
+  // Register |j_surface| with ID |surface_id|, which must be not in use.
   void RegisterViewSurface(int surface_id, jobject j_surface);
+
+  // Register |j_surface| with a new surface ID and return the ID.
+  int RegisterViewSurface(jobject j_surface);

[boliu, 2017/03/30 22:42:02]

err, I asked this to be refactored when this code moved here, but I guess that
never happened.

So before this CL, surface_map_ and surface_view_map_ are parallel arrays, so we
should code it as a single map

and then I think this CL is allowing a surface view to be registered without a
AcceleratedWidget. imo that's easier to understand?

[liberato (no reviews please), 2017/04/04 17:49:28]

sorry about that.  will refactor per our offline discussion.  the CL is
https://codereview.chromium.org/2791723003/

[boliu, 2017/04/04 23:53:21]

Oh I originally asked someone else, not you

Thanks for refactoring this :)

+
   void UnregisterViewSurface(int surface_id);
   gl::ScopedJavaSurface AcquireJavaSurface(int surface_id) override;
 #endif
 
   // Gets the global instance of the surface tracker.
   static GpuSurfaceTracker* Get() { return GetInstance(); }
 
   // Adds a surface for a native widget. Returns the surface ID.
   int AddSurfaceForNativeWidget(gfx::AcceleratedWidget widget);
 
@@ skipping 28 matching lines @@
   SurfaceViewMap surface_view_map_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(GpuSurfaceTracker);
 };
 
 }  // namespace ui
 
 #endif  // GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_