Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2765423003: Add presubmit check to warn against using NULL (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add presubmit check to warn against using NULL BUG=704361 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2765423003 Cr-Commit-Position: refs/heads/master@{#460485} Committed: https://chromium.googlesource.com/chromium/src/+/e7caaa9b45386f0061c6d5e33ec893a951b12c5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Tom (Use chromium acct)
dpranke@ ptal
3 years, 9 months ago (2017-03-23 19:24:34 UTC) #1
Tom (Use chromium acct)
-dpranke +thakis can you look at this one too
3 years, 8 months ago (2017-03-28 19:26:14 UTC) #3
Nico
I'm not a PRESUBMIT OWNER.
3 years, 8 months ago (2017-03-28 19:27:42 UTC) #6
Tom (Use chromium acct)
-thakis +phajdan ptal
3 years, 8 months ago (2017-03-28 19:33:09 UTC) #8
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-03-29 19:00:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765423003/1
3 years, 8 months ago (2017-03-29 19:04:04 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:23:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7caaa9b45386f0061c6d5e33ec8...

Powered by Google App Engine
This is Rietveld 408576698