ash: Map/unmap GMB for each laser pointer update.

ash: Map/unmap GMB for each laser pointer update.

GMB implementations are allowed to return cached memory
that requires a flush after being written for changes to
be available to the GPU. Call Map/Unmap() to give GMB
implementations a chance to flush if required.

BUG=696385
Review-Url: https://codereview.chromium.org/2765393004
Cr-Commit-Position: refs/heads/master@{#459294}
Committed: https://chromium.googlesource.com/chromium/src/+/f608cd276feb05c7d6d5354ee658fd37db48a7c6

[reveman, 2017-03-23 05:05:41]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org, hoegsberg@chromium.org

[reveman, 2017-03-23 16:28:43]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 16:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:11:02]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2017-03-23 22:56:19]

LGTM.
You might want to mention in the description about different GMBs cache
behaviors.

[reveman, 2017-03-23 23:00:31]

Description was changed from

==========
ash: Map/unmap GMB for each laster pointer update.

This gives GMB implementations a chance to flush if required.

BUG=696385
==========

to

==========
ash: Map/unmap GMB for each laser pointer update.

GMB implementations are allowed to return cached memory
that requires a flush after being written for changes to
be available to the GPU. Call Map/Unmap() to give GMB
implementations a chance to flush if required.

BUG=696385
==========

[reveman, 2017-03-23 23:01:18]

reveman@chromium.org changed reviewers:
+ derat@chromium.org

[reveman, 2017-03-23 23:01:18]

+derat for owner review

On 2017/03/23 at 22:56:19, dcastagna wrote:
> LGTM.
> You might want to mention in the description about different GMBs cache
behaviors.

Done.

[Daniel Erat, 2017-03-23 23:45:52]

lgtm

[reveman, 2017-03-24 00:12:17]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:17:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490314337859080, "parent_rev":
"5e488721e5f9119b9cd772ca02891188a6d83383", "commit_rev":
"f608cd276feb05c7d6d5354ee658fd37db48a7c6"}

[commit-bot: I haz the power, 2017-03-24 00:18:35]

Description was changed from

==========
ash: Map/unmap GMB for each laser pointer update.

GMB implementations are allowed to return cached memory
that requires a flush after being written for changes to
be available to the GPU. Call Map/Unmap() to give GMB
implementations a chance to flush if required.

BUG=696385
==========

to

==========
ash: Map/unmap GMB for each laser pointer update.

GMB implementations are allowed to return cached memory
that requires a flush after being written for changes to
be available to the GPU. Call Map/Unmap() to give GMB
implementations a chance to flush if required.

BUG=696385

Review-Url: https://codereview.chromium.org/2765393004
Cr-Commit-Position: refs/heads/master@{#459294}
Committed:
https://chromium.googlesource.com/chromium/src/+/f608cd276feb05c7d6d5354ee658...
==========

[commit-bot: I haz the power, 2017-03-24 00:18:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f608cd276feb05c7d6d5354ee658...