milo/appengine/buildbot/build.go - Issue 2765383002: Milo: Move instance configuration to luci-config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/build.go

Issue 2765383002: Milo: Move instance configuration to luci-config (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/build.go

diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go

index c6f7e0c977bd902aaa08dbc5e956b1119dfebc83..4745c78497cb4b481a80a840e41e0a03cf54050b 100644

--- a/milo/appengine/buildbot/build.go

+++ b/milo/appengine/buildbot/build.go

@@ -143,7 +143,6 @@ func summary(c context.Context, b *buildbotBuild) resp.BuildComponent {

}

source := &resp.Link{

Label: fmt.Sprintf("%s/%s/%d", b.Master, b.Buildername, b.Number),

- // TODO(hinoka): Internal builds.

URL: fmt.Sprintf(

"https://%s/%s/builders/%s/builds/%d",

host, b.Master, b.Buildername, b.Number),

« no previous file with comments | « no previous file | milo/appengine/buildbot/build_test.go » ('j') | milo/appengine/buildbot/pubsub.go » ('J')