Milo: Move instance configuration to luci-config

milo/appengine/buildbot/build.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "errors"
         "fmt"
@@ skipping 95 matching lines @@
         }()
         if osLogo != nil {
                 return &resp.LogoBanner{
                         OS: []resp.Logo{*osLogo},
                 }
         }
         logging.Warningf(c, "No OS info found.")
         return nil
 }
 
 // summary Extract the top level summary from a buildbot build as a

[nodir, 2017/03/24 08:41:15]

extracts

[hinoka, 2017/03/28 17:47:20]

Done.

 // BuildComponent
 func summary(c context.Context, b *buildbotBuild) resp.BuildComponent {
         // TODO(hinoka): use b.toStatus()
         // Status
         var status resp.Status
         if b.Currentstep != nil {
                 status = resp.Running
         } else {
                 status = result2Status(b.Results)
         }
 
         // Timing info
         started, ended, duration := parseTimes(b.Times)
 
         // Link to bot and original build.
         server := "build.chromium.org/p"
         if b.Internal {
                 server = "uberchromegw.corp.google.com/i"
         }
         bot := &resp.Link{
                 Label: b.Slave,
                 URL:   fmt.Sprintf("https://%s/%s/buildslaves/%s", server, b.Master, b.Slave),
         }
         host := "build.chromium.org/p"
         if b.Internal {
                 host = "uberchromegw.corp.google.com/i"
         }
         source := &resp.Link{
                 Label: fmt.Sprintf("%s/%s/%d", b.Master, b.Buildername, b.Number),
-                // TODO(hinoka): Internal builds.
                 URL: fmt.Sprintf(
                         "https://%s/%s/builders/%s/builds/%d",
                         host, b.Master, b.Buildername, b.Number),
         }
 
         // The link to the builder page.
         parent := &resp.Link{
                 Label: b.Buildername,
                 URL:   ".",
         }
@@ skipping 367 matching lines @@
 
         // TODO(hinoka): Do all fields concurrently.
         return &resp.MiloBuild{
                 SourceStamp:   sourcestamp(c, b),
                 Summary:       summary(c, b),
                 Components:    components(b),
                 PropertyGroup: properties(b),
                 Blame:         blame(b),
         }, nil
 }