chrome/browser/chromeos/options/network_property_ui_data_unittest.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc ('k') | chrome/browser/chromeos/policy/auto_enrollment_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

diff --git a/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc b/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

index adb1885241584f8549534ef572942dd68293d82c..0cc2d79b245c07af68334a2f188e4888582fd892 100644

--- a/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

+++ b/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

@@ -46,16 +46,16 @@ TEST_F(NetworkPropertyUIDataTest, ParseOncProperty) {

base::Value val_a_a("a_a");

base::Value val_a_b("a_b");

- onc.Set("a", val_a.DeepCopy());

- onc.Set("b", val_b.DeepCopy());

- onc.Set("a.a", val_a_a.DeepCopy());

- onc.Set("a.b", val_a_b.DeepCopy());

+ onc.Set("a", val_a.CreateDeepCopy());

+ onc.Set("b", val_b.CreateDeepCopy());

+ onc.Set("a.a", val_a_a.CreateDeepCopy());

+ onc.Set("a.b", val_a_b.CreateDeepCopy());

base::ListValue recommended;

recommended.AppendString("b");

recommended.AppendString("c");

recommended.AppendString("a.a");

- onc.Set("Recommended", recommended.DeepCopy());

- onc.Set("a.Recommended", recommended.DeepCopy());

+ onc.Set("Recommended", recommended.CreateDeepCopy());

+ onc.Set("a.Recommended", recommended.CreateDeepCopy());

NetworkPropertyUIData prop;