chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc ('k') | chrome/browser/chromeos/options/network_property_ui_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

index e5e4cd2605d7f70400e0b11dd2306ccfd84d5f27..9c740c705fecbb7e906efa5b8af5ae6d8dfce091 100644

--- a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

+++ b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

@@ -544,10 +544,12 @@ void UserImageManagerImpl::Job::UpdateLocalState() {

return;

std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue);

- entry->Set(kImagePathNodeName, new base::Value(image_path_.value()));

- entry->Set(kImageIndexNodeName, new base::Value(image_index_));

+ entry->Set(kImagePathNodeName,

+ base::MakeUnique<base::Value>(image_path_.value()));

+ entry->Set(kImageIndexNodeName, base::MakeUnique<base::Value>(image_index_));

if (!image_url_.is_empty())

- entry->Set(kImageURLNodeName, new base::Value(image_url_.spec()));

+ entry->Set(kImageURLNodeName,

+ base::MakeUnique<base::Value>(image_url_.spec()));

DictionaryPrefUpdate update(g_browser_process->local_state(),

kUserImageProperties);

update->SetWithoutPathExpansion(user_id(), entry.release());