Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2765353005: ntp_snippets: update string based on feedback (Closed)

Created:
3 years, 9 months ago by sfiera
Modified:
3 years, 9 months ago
Reviewers:
jkrcal
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ntp_snippets: update string based on feedback The English string wasn't entirely clear about who published the headlining article and the other articles, so it was hard to translate. Review-Url: https://codereview.chromium.org/2765353005 Cr-Commit-Position: refs/heads/master@{#459408} Committed: https://chromium.googlesource.com/chromium/src/+/36149174663fae3fa4623b5014823e19c61545db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/ntp_snippets_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sfiera
Please feel free to ask for more clarification if the string still isn't clear!
3 years, 9 months ago (2017-03-24 12:26:33 UTC) #2
jkrcal
lgtm
3 years, 9 months ago (2017-03-24 12:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765353005/1
3 years, 9 months ago (2017-03-24 12:45:02 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:39:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36149174663fae3fa4623b501482...

Powered by Google App Engine
This is Rietveld 408576698