[Builtins] Provide a code-stub impl. of Array.prototype.map

[Builtins] Provide a code-stub impl. of Array.prototype.map

BUG=

Review-Url: https://codereview.chromium.org/2765293002
Cr-Commit-Position: refs/heads/master@{#44093}
Committed: https://chromium.googlesource.com/v8/v8/+/69e02958d31ac939db13f6e55ad1d62c1a57de3c

[mvstanton, 2017-03-22 14:41:09]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 14:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 14:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:57:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-03-22 20:20:25]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 20:20:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 20:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:46:45]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-03-22 22:19:45]

mvstanton@chromium.org changed reviewers:
+ danno@chromium.org

[mvstanton, 2017-03-22 22:19:45]

Hi Danno,
Here is map to add to our collection :)
thanks,
Michael

[danno, 2017-03-23 12:25:05]

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
src/builtins/builtins-array-gen.cc:135: 
Nit: Elsewhere we group the *Generator/*Filters together. Can you move this
after FilterProcessor?

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
src/builtins/builtins-array-gen.cc:160: Node* const p_k = ToString(context(),
k);
I wonder if you really need the ToString here, because CreateDataPropery should
be able to deal with all Numbers as property keys, and k is guaranteed to be a
Number, right?

https://codereview.chromium.org/2765293002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2765293002/diff/60001/src/flag-definitions.h#...
src/flag-definitions.h:774: DEFINE_BOOL(experimental_fast_array_builtins, true,
Probably want to keep this off for now ;-)

[mvstanton, 2017-03-24 09:35:49]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:35:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-24 09:37:08]

Thanks Danno, comments addressed!
--Michael

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
src/builtins/builtins-array-gen.cc:135: 
On 2017/03/23 12:25:04, danno wrote:
> Nit: Elsewhere we group the *Generator/*Filters together. Can you move this
> after FilterProcessor?

Done.

https://codereview.chromium.org/2765293002/diff/60001/src/builtins/builtins-a...
src/builtins/builtins-array-gen.cc:160: Node* const p_k = ToString(context(),
k);
On 2017/03/23 12:25:04, danno wrote:
> I wonder if you really need the ToString here, because CreateDataPropery
should
> be able to deal with all Numbers as property keys, and k is guaranteed to be a
> Number, right? 

Done. This prompted some comment cleanup, to annotate what is happening
vis-a-vis the spec better.

https://codereview.chromium.org/2765293002/diff/60001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2765293002/diff/60001/src/flag-definitions.h#...
src/flag-definitions.h:774: DEFINE_BOOL(experimental_fast_array_builtins, true,
On 2017/03/23 12:25:04, danno wrote:
> Probably want to keep this off for now ;-)

Done.

[commit-bot: I haz the power, 2017-03-24 09:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:42:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37536)

[danno, 2017-03-24 09:57:33]

lgtm

[mvstanton, 2017-03-24 10:24:05]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2017-03-24 10:24:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 11:01:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490351045488210,
"parent_rev": "f764a5c8c0c973a1996b2f86e009b592771bd8c4", "commit_rev":
"69e02958d31ac939db13f6e55ad1d62c1a57de3c"}

[commit-bot: I haz the power, 2017-03-24 11:01:59]

Description was changed from

==========
[Builtins] Provide a code-stub impl. of Array.prototype.map

BUG=
==========

to

==========
[Builtins] Provide a code-stub impl. of Array.prototype.map

BUG=

Review-Url: https://codereview.chromium.org/2765293002
Cr-Commit-Position: refs/heads/master@{#44093}
Committed:
https://chromium.googlesource.com/v8/v8/+/69e02958d31ac939db13f6e55ad1d62c1a5...
==========

[commit-bot: I haz the power, 2017-03-24 11:02:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/69e02958d31ac939db13f6e55ad1d62c1a5...