Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2765123002:
Removed use of FrameHost in FrameView.cpp (Closed)
DescriptionRemoved use of FrameHost in FrameView.cpp
This is pre-work to remove FrameHost.
BUG=688614
Review-Url: https://codereview.chromium.org/2765123002
Cr-Commit-Position: refs/heads/master@{#458662}
Committed: https://chromium.googlesource.com/chromium/src/+/ba66233b874fd4f9faac1feed4dbe1a83e6458ed
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Removed BUG=688614 ========== to ========== Removed use of FrameHost in FrameView.cpp This is pre-work to remove FrameHost. BUG=688614 ==========
sashab@chromium.org changed reviewers: + joelhockey@chromium.org
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
sashab@chromium.org changed reviewers: + dcheng@chromium.org
Ty joel. dcheng ptal
lgtm lgtm
The CQ bit was unchecked by sashab@chromium.org
LGTM
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490161119003300, "parent_rev":
"80f26196daa91b9df37899dfb04fe005bed2941d", "commit_rev":
"ba66233b874fd4f9faac1feed4dbe1a83e6458ed"}
Message was sent while issue was closed.
Description was changed from ========== Removed use of FrameHost in FrameView.cpp This is pre-work to remove FrameHost. BUG=688614 ========== to ========== Removed use of FrameHost in FrameView.cpp This is pre-work to remove FrameHost. BUG=688614 Review-Url: https://codereview.chromium.org/2765123002 Cr-Commit-Position: refs/heads/master@{#458662} Committed: https://chromium.googlesource.com/chromium/src/+/ba66233b874fd4f9faac1feed4db... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ba66233b874fd4f9faac1feed4db... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
