Revert of MediaStreamSource: verify unlocked state when finalizing.

Revert of MediaStreamSource: verify unlocked state when finalizing. (patchset #1 id:1 of https://codereview.chromium.org/2741663004/ )

Reason for revert:
Diagnosis completed, reverting (cf. https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 )

Original issue's description:
> MediaStreamSource: verify unlocked state when finalizing.
>
> To diagnose an audio thread crash condition, verify that the lock
> over audio consumers that MediaStreamSource keeps, isn't held when it is
> being finalized. If it is, then the audio thread is active using the
> MediaStreamSource object..which is not a well-formed state to be in.
>
> R=
> BUG=682945
>
> Review-Url: https://codereview.chromium.org/2741663004
> Cr-Commit-Position: refs/heads/master@{#456029}
> Committed: https://chromium.googlesource.com/chromium/src/+/c662576c8bb7cecef0dd9a699112fa5cc4b6ab79

TBR=hongchan@chromium.org,haraken@chromium.org,rtoy@chromium.org,guidou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682945
Review-Url: https://codereview.chromium.org/2765073004
Cr-Commit-Position: refs/heads/master@{#458744}
Committed: https://chromium.googlesource.com/chromium/src/+/ff2aec5610d70900cb97590c8036843e21cb1cc8

[sof, 2017-03-22 09:59:38]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-03-22 09:59:38]

Created Revert of MediaStreamSource: verify unlocked state when finalizing.

[commit-bot: I haz the power, 2017-03-22 09:59:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-03-22 10:40:45]

lgtm

[haraken, 2017-03-22 10:41:51]

LGTM

[commit-bot: I haz the power, 2017-03-22 11:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 11:54:08]

Failed to apply patch for
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:54
  error: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:
patch does not apply

Patch:      
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
Index: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
diff --git
a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
index
c65890142bb5e89ae772586390be824b963dc1c5..98a314d3c753aad2b98759a2142bc525fd8e9caf
100644
--- a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
+++ b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
@@ -54,13 +54,6 @@
       m_remote(remote),
       m_readyState(readyState),
       m_requiresConsumer(requiresConsumer) {}
-
-MediaStreamSource::~MediaStreamSource() {
-  // Verify that the audio thread isn't consuming audio.
-  // TODO(sof): remove once crbug.com/682945 has been diagnosed.
-  MutexTryLocker tryLocker(m_audioConsumersLock);
-  CHECK(tryLocker.locked());
-}
 
 void MediaStreamSource::setReadyState(ReadyState readyState) {
   if (m_readyState != ReadyStateEnded && m_readyState != readyState) {

[sof, 2017-03-22 12:41:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-03-22 12:42:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 12:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 12:45:50]

Failed to apply patch for
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:54
  error: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp:
patch does not apply

Patch:      
third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
Index: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
diff --git
a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
index
c65890142bb5e89ae772586390be824b963dc1c5..98a314d3c753aad2b98759a2142bc525fd8e9caf
100644
--- a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
+++ b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
@@ -54,13 +54,6 @@
       m_remote(remote),
       m_readyState(readyState),
       m_requiresConsumer(requiresConsumer) {}
-
-MediaStreamSource::~MediaStreamSource() {
-  // Verify that the audio thread isn't consuming audio.
-  // TODO(sof): remove once crbug.com/682945 has been diagnosed.
-  MutexTryLocker tryLocker(m_audioConsumersLock);
-  CHECK(tryLocker.locked());
-}
 
 void MediaStreamSource::setReadyState(ReadyState readyState) {
   if (m_readyState != ReadyStateEnded && m_readyState != readyState) {

[sof, 2017-03-22 12:55:14]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-03-22 12:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, guidou@chromium.org
Link to the patchset: https://codereview.chromium.org/2765073004/#ps70001
(title: "rebased upto r458724")

[commit-bot: I haz the power, 2017-03-22 12:55:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 14:31:30]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1490187314880540,
"parent_rev": "44b8e6b6355c3a0fe61bc6bfb38fb63632618a81", "commit_rev":
"ff2aec5610d70900cb97590c8036843e21cb1cc8"}

[commit-bot: I haz the power, 2017-03-22 14:32:44]

Description was changed from

==========
Revert of MediaStreamSource: verify unlocked state when finalizing. (patchset #1
id:1 of https://codereview.chromium.org/2741663004/ )

Reason for revert:
Diagnosis completed, reverting (cf.
https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 )

Original issue's description:
> MediaStreamSource: verify unlocked state when finalizing.
> 
> To diagnose an audio thread crash condition, verify that the lock
> over audio consumers that MediaStreamSource keeps, isn't held when it is
> being finalized. If it is, then the audio thread is active using the
> MediaStreamSource object..which is not a well-formed state to be in.
> 
> R=
> BUG=682945
> 
> Review-Url: https://codereview.chromium.org/2741663004
> Cr-Commit-Position: refs/heads/master@{#456029}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c662576c8bb7cecef0dd9a699112...

TBR=hongchan@chromium.org,haraken@chromium.org,rtoy@chromium.org,guidou@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682945
==========

to

==========
Revert of MediaStreamSource: verify unlocked state when finalizing. (patchset #1
id:1 of https://codereview.chromium.org/2741663004/ )

Reason for revert:
Diagnosis completed, reverting (cf.
https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 )

Original issue's description:
> MediaStreamSource: verify unlocked state when finalizing.
>
> To diagnose an audio thread crash condition, verify that the lock
> over audio consumers that MediaStreamSource keeps, isn't held when it is
> being finalized. If it is, then the audio thread is active using the
> MediaStreamSource object..which is not a well-formed state to be in.
>
> R=
> BUG=682945
>
> Review-Url: https://codereview.chromium.org/2741663004
> Cr-Commit-Position: refs/heads/master@{#456029}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c662576c8bb7cecef0dd9a699112...

TBR=hongchan@chromium.org,haraken@chromium.org,rtoy@chromium.org,guidou@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682945

Review-Url: https://codereview.chromium.org/2765073004
Cr-Commit-Position: refs/heads/master@{#458744}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff2aec5610d70900cb97590c8036...
==========

[commit-bot: I haz the power, 2017-03-22 14:32:45]

Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/ff2aec5610d70900cb97590c8036...